This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Create action_trace & action_receipt on hard_fail #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n action throws exception. This provides action information even on hard_fail which previously generated a default constructed action_trace.
…pt and action_trace with known values. Add finalize_trace method to set trace values after execution.
heifner
changed the title
arhag
suggested changes
Oct 11, 2018
|
|
||
| trx_context.executed.emplace_back( move(r) ); | ||
|
|
||
| if ( control.contracts_console() ) { | ||
| print_debug(receiver, t); | ||
| print_debug(receiver, trace); |
There was a problem hiding this comment.
print_debug will be passed a trace with an empty console since it hasn't been set yet with finalize_trace. It should be moved to after the finalize_trace call below.
heifner
changed the title
|
Note I had to move the setting of |
arhag
approved these changes
Oct 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hard_failwas creating default constructedaction_traceto be added totransaction_traceaction_traceandaction_receipteven when exception while processing actionexcepttoaction_traceto store exception that is also stored ontransaction_traceaction_tracewhich will likely cause problems withhistory_pluginunless full replay