This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
add DB guard check for nodeos_under_min_avail_ram.py #7291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taokayan
changed the title
Kayan db guard test
add DB guard check for nodeos_under_min_avail_ram.py
May 7, 2019
brianjohnson5972
previously approved these changes
May 7, 2019
heifner
suggested changes
May 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should target develop
. I see no reason to add it to the 1.8.x release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to not approved, so we get the merge problem, pointed out by Kevin, taken care of
brianjohnson5972
dismissed
their stale review
May 7, 2019 14:26
Changing to not approved, so we get the merge problem, pointed out by Kevin, taken care of
hey @heifner @brianjohnson5972 I've re-based please check it again. |
test case
|
brianjohnson5972
approved these changes
May 9, 2019
heifner
approved these changes
May 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added DB guard check for existing test nodeos_under_min_avail_ram.py #7214
Consensus Changes
N/A
API Changes
N/A
Documentation Additions
N/A