This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[1.8.x] Forked PR fix #7917
Merged
[1.8.x] Forked PR fix #7917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 13, 2019 17:54
arhag
approved these changes
Sep 13, 2019
arhag
approved these changes
Sep 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When running a build using
pull/7841/head:7646-chain-id-in-blog(a forked PR), anka/mac tries to git clone without doing a fetch of the PR and cannot find the commit ID. This solution mimics what buildkite does on the host to clone/fetch/checkout, but inside of the anka VM.Additionally, anka VMs mount using FUSEFS and it's awfully slow. This is why we git clone inside of the VM (linux doesn't have this problem).
Consensus Changes
API Changes
Documentation Additions