Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Refactor producer plugin start_block - 1.8 #7934

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Refactor producer plugin start_block - 1.8 #7934

merged 3 commits into from
Sep 20, 2019

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Sep 16, 2019 •
edited
Loading

Change Description

  • Refactor the producer plugin start_block into a few methods to make the logic easier to follow.
  • Refactoring is normally not done in release branches but would like to get this into 1.7, 1.8, and develop otherwise the difference in code will make it more difficult to apply fixes if they are needed in the future.
  • 1.7 & develop versions of fix will be created after this is peer-reviewed.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner heifner merged commit 2e7097d into release/1.8.x Sep 20, 2019
@heifner heifner deleted the producer-plugin-cleanup-1.8 branch September 20, 2019 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arhag arhag arhag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heifner @arhag