Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Reduce logging for failed http plugin calls #9778

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Dec 12, 2020

Change Description

  • Public API nodes with default info level logging for http_plugin have huge logs filled with:
Dec 12 00:00:13 node1 nodeos[29695]: error 2020-12-12T00:00:13.966 nodeos    http_plugin.cpp:964           handle_exception     ] FC Exception encountered while processing chain.push_transaction
Dec 12 00:00:14 node1 nodeos[29695]: error 2020-12-12T00:00:14.061 nodeos    http_plugin.cpp:964           handle_exception     ] FC Exception encountered while processing chain.push_transaction

This PR reduces this noise. Full details can be enabled via debug logging for private API nodes. There is no error in the system if a push_transaction generates an exception. That is normal operating conditions.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@brianjohnson5972 brianjohnson5972 merged commit 7d5d910 into develop Dec 18, 2020
@heifner heifner deleted the log-spam branch January 29, 2021 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants