This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-cpu
reviewed
Feb 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to Dockerfile for consistency.
zach-cpu
approved these changes
Feb 5, 2021
zach-cpu
approved these changes
Feb 5, 2021
scottarnette
previously approved these changes
Feb 5, 2021
zach-cpu
previously approved these changes
Feb 5, 2021
kj4ezj
suggested changes
Feb 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're making these other changes anyways, I'd also recommend removing the blank lines. They serve no purpose. But, that is up to you.
cocho-gore
dismissed stale reviews from zach-cpu and scottarnette
via
February 5, 2021 19:14
e718159
kj4ezj
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐳
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
From AUTO-457, we are working on providing the EOSIO community minimal docker images via Docker Hub which they can pull to more easily use our tooling in a clean environment. We have already introduced a docker image for EOSIO, so this pull request creates one for EOSIO.CDT.
API Changes
Documentation Additions
Public docker images are now available at docker.io/eosio/eosio.cdt.