This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
update transaction to dawn-v3.0.0 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot about one of the repos. This also depends on EOSIO/eosjs-api#5 . |
|
Cool! thanks .. I'm looking into getting a dawn3 in docker. Right now the daily images may or may not be the exact release. When I get that going this will be easy to check and merge. |
|
I forgot to check the C++ serializer's naming before making the changes. It serializes fc::unsigned_int as "varuint32". |
|
@jcalfee I'm working on another fix to fcbuffer (it tries to use Node's Buffer operations on a Uint8Array I pass in). The problem is it's on top of this unrelated fix since that's the only way I can test. How should I produce the pull request? Create a new one that also pulls in the dawn 3 fix? Add it to the dawn 3 pull request? |
Closed
|
merged in #52 |
metamaster2021
pushed a commit
to armoniax/eosjs
that referenced
this pull request
May 7, 2022
eos-vm, threaded server
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on EOSIO/eosjs-fcbuffer#4 and EOSIO/eosjs-json#5