Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix tapos check #556

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Fix tapos check #556

merged 2 commits into from
Jun 7, 2019

Conversation

c0d3ster
Copy link
Contributor

@c0d3ster c0d3ster commented Jun 7, 2019

Change Description

Modified the conditional in hasRequiredTaposFields to use typeof() === 'number' instead of a truthiness check for the fields. As seen in the excerpt below from the transaction header file, both of these fields are unsigned integers and should be confirmed as numbers to allow the 0 case to pass.

uint16_t               ref_block_num       = 0U; ///< specifies a block num in the last 2^16 blocks.
uint32_t               ref_block_prefix    = 0UL; ///< specifies the lower 32 bits of the blockid at get_ref_blocknum

Addresses #554

@tbfleming tbfleming merged commit 1fed0be into develop Jun 7, 2019
Copy link

@zquestz zquestz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. This fixes my issue. =)

@gleehokie gleehokie deleted the fix-tapos-check branch June 18, 2019 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants