This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fixing sign() method #605
Merged
Fixing sign() method #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2019 21:58
jeffreyssmith2nd
approved these changes
Nov 12, 2019
c0d3ster
approved these changes
Nov 12, 2019
| @@ -41,7 +41,7 @@ export class Signature { | |||
| const r = new BN(this.signature.data.slice(1, lengthOfR + 1)); | |||
| const s = new BN(this.signature.data.slice(lengthOfR + 1, lengthOfR + lengthOfS + 1)); | |||
|
|
|||
| const recoveryParam = this.signature.data[0] - 27 - 4; | |||
| const recoveryParam = (this.signature.data[0] - 27) & 3; | |||
There was a problem hiding this comment.
ah yes of course & 3 not - 4
tbfleming
reviewed
Nov 12, 2019
| @@ -43,6 +43,7 @@ | |||
| "babel-preset-stage-1": "6.24.1", | |||
| "cypress": "3.1.5", | |||
| "elliptic": "^6.5.0", | |||
| "eosjs-ecc": "^4.0.7", | |||
There was a problem hiding this comment.
This is in the dev dependencies for testing compatibility with previous methodologies
There was a problem hiding this comment.
eosjs-ecc is going away; we shouldn't depend on it.
There was a problem hiding this comment.
It's not in the produced library; it's only here in devDependencies to verify that what we're producing now matches what it used to produce.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixing some tiny and critical coding error
API Changes
Documentation Additions