This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix security issues #639
Merged
Fix security issues #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlamarr22
force-pushed
the
security-audit
branch
from
dad3180
to
0dc6be5
Compare
jlamarr22
force-pushed
the
security-audit
branch
2 times, most recently
from
bf1fe9a
to
e810a83
Compare
jlamarr22
commented
Jan 3, 2020
| "webpack-cli": "3.2.3" | ||
| }, | ||
| "resolutions": { | ||
| "braces": "^2.3.1" |
There was a problem hiding this comment.
There is an issue with upgrading to jest version 24. Tests break around TextEncoder/TextDecoder (seems like versioning of some sort), so this is the easiest way to fix this for now.
There was a problem hiding this comment.
Removing text-encoding package fixes this, but causes test issues.
jlamarr22
force-pushed
the
security-audit
branch
from
e810a83
to
ce1224c
Compare
lock lockfile Stop gap. Need to update jest, but causing error due to Buffer Update Fix without resolutions Remove textdecoder Revert
jlamarr22
force-pushed
the
security-audit
branch
from
ce03fb5
to
1cd764d
Compare
jeffreyssmith2nd
approved these changes
Jan 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fix security issues on for release
API Changes
Documentation Additions