This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
eosjs-ecc methods and migration (release/21.0.x branch) #709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Following feedback and requests, the ecc helper functions have been renamed to match the
eosjs-ecc
methods where possible. A private key generation method has also been added, as well as aPublicKey.toLegacyString()
method for backwards compatibility.Lastly, an
ecc
exported object is available with all the functionseosjs-ecc
has that utilizes the new functions.Second PR to cherry pick commits to release/21.0.x branch
API Changes
Changed:
sign
,verify
, andrecover
now have the argumentshouldHash
that by default is set totrue
. These functions will hash the data given but can accept already hashed data withshouldHash
=false
PublicKey.validate
was renamed toPublicKey.isValid
Signature.recoverPublicKey
was renamed toSignature.recover
New:
PrivateKey.toLegacyString
: Convert private key to Legacy EOSIO-format private keyPrivateKey.isValid
: Validate a private keyPublicKey.toLegacyString
: Convert public key to Legacy EOSIO-format public keygenerateKeyPair
: Utilizes theelliptic
package to generate a public and private key pair. This function should only be used in secure environments and requires an environment variable to be set to confirm that the environment is secure.sha256
: An exported sha256 function from theelliptic
packageDocumentation Additions