-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: format options #1006
feat: format options #1006
Conversation
I can use the |
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
update test to use real world data
d4c05ee
to
e760d9b
Compare
e760d9b
to
2daf65a
Compare
…or init method in stories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After integration testing and changing how the parameters are passed all seems to work as expected, so let's merge, thank you!
This PR implements the possibility to use format options, additionally to the simple syntax that was implemented before. If the format is supposed to use a projection, that projection has to be registered via
eoxMap.registerProjection(...)
beforehand, like this has already to be done for view projections.Because ol formats are very diverse in their appearance, i have left typing to a minimum, only requiring the "type" (like
GeoJSON
), and optional propertiesdataProjection
andfeatureProjection
, as i suppose that these will be the most used ones. Format options vary widely,@ts-ignore
s will be needed for more exotic formats.example simple format (unchanged):
example format with options:
Checklist before requesting a review
closes #999