-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feature editor with shape upload and drag&drop #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…ature/shape-upload-paste
…ature/shape-upload-paste
5 tasks
Thank you, this looks very good, but I am waiting for comments at #667 before merging this. |
silvester-pari
approved these changes
Feb 22, 2024
silvester-pari
changed the title
Feat: Drawtool shape upload - drag and drop
feat: feature editor with shape upload and drag&drop
Feb 22, 2024
This was referenced Feb 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Allowing users to upload/paste shape files directly to the
drawtools
Implemented Changes
show-editor
: Activates the editor withindrawtools
.import-features
: Enables the capability to upload, drag and drop files intodrawtools
.GeoJSON
. Any uploaded files in different formats will be automatically converted toGeoJSON
.eox-map
, eliminating the need to import anyOL
files directly intoeox-drawtools
.eox-map
namedparseFeature()
.Note: I have only added a single test for copy rest not able to add because
drawtool
tests are partially implemented and not fully able to draw and update things.Screenshots/Videos
ScreenRecording2024-02-19at11.48.19AM-ezgif.com-resize-video.mp4
Checklist before requesting a review