Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feature editor with shape upload and drag&drop #649

Merged
merged 24 commits into from
Feb 22, 2024

Conversation

srijitcoder
Copy link
Collaborator

@srijitcoder srijitcoder commented Feb 13, 2024

Context

Allowing users to upload/paste shape files directly to the drawtools

Implemented Changes

  • Two attributes have been introduced for specific functionalities:
    • show-editor: Activates the editor within drawtools.
    • import-features: Enables the capability to upload, drag and drop files into drawtools.
  • Users have the ability to upload, paste, or drag and drop three primary shapefile formats:
    • GeoJSON
    • TopoJSON
    • KML
  • However, the primary shapefile format supported by the editor is GeoJSON. Any uploaded files in different formats will be automatically converted to GeoJSON.
  • The editor includes a copy button to facilitate the copying of GeoJSON data.
  • All OpenLayers (OL) implementations are encapsulated within eox-map, eliminating the need to import any OL files directly into eox-drawtools.
  • The user interface for the editor is compatible with CSS variables.
  • A beautified version of GeoJSON is generated whenever features are modified, utilizing a function implemented inside eox-map named parseFeature().

Note: I have only added a single test for copy rest not able to add because drawtool tests are partially implemented and not fully able to draw and update things.

Screenshots/Videos

ScreenRecording2024-02-19at11.48.19AM-ezgif.com-resize-video.mp4

Checklist before requesting a review

@srijitcoder srijitcoder marked this pull request as draft February 13, 2024 10:14
@srijitcoder srijitcoder linked an issue Feb 15, 2024 that may be closed by this pull request
@srijitcoder srijitcoder added enhancement New feature or request drawtools labels Feb 19, 2024
@srijitcoder srijitcoder marked this pull request as ready for review February 19, 2024 06:45
@silvester-pari
Copy link
Collaborator

Thank you, this looks very good, but I am waiting for comments at #667 before merging this.

@silvester-pari silvester-pari changed the title Feat: Drawtool shape upload - drag and drop feat: feature editor with shape upload and drag&drop Feb 22, 2024
@silvester-pari silvester-pari merged commit 71acb56 into main Feb 22, 2024
3 checks passed
@silvester-pari silvester-pari deleted the drawtools/feature/shape-upload-paste branch February 22, 2024 14:15
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
drawtools enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shape upload/paste
2 participants