Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render high-density slider ticks correctly #1221

Merged
merged 7 commits into from
Aug 19, 2024

Conversation

spectrachrome
Copy link
Member

@spectrachrome spectrachrome commented Aug 19, 2024

Implemented changes

During the development of the performance fix for the Time Control slider ticks, I noticed that the year marks were not being rendered correctly with a larger number of dates (~2000).

This pull request revamps the tick system to work correctly with both low-density and high-density data.

Screenshots/Videos

Screen Recording 2024-08-19 at 17 53 45

Checklist before requesting a review

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 7dfa0a1
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/66c371c0bb8a5d0008cee4b2
😎 Deploy Preview https://deploy-preview-1221--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@spectrachrome spectrachrome changed the title fix: render high-density slider-ticks correctly fix: render high-density slider ticks correctly Aug 19, 2024
@spectrachrome spectrachrome marked this pull request as ready for review August 19, 2024 16:09
@silvester-pari silvester-pari merged commit fc272f1 into main Aug 19, 2024
7 checks passed
@silvester-pari silvester-pari deleted the timecontrol/fix/high-density-yearmarks branch August 19, 2024 16:27
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
@spectrachrome spectrachrome self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants