-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BackendEnd] Add support for verilog units in the experimental backend. #107
Conversation
… during Verilog writing. Commented out assertion in verilog modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few super minor comments.
Again, install and run clang-format on your code. Some of the C++ files are clearly not formatted correctly.
tools/backend/rtl-constant-generator-verilog/rtl-constant-generator-verilog.cpp
Outdated
Show resolved
Hide resolved
I was fixing an issue today (that you had reported to me) in the RTL exporter and took the opportunity to integrate a clean solution to the Verilog port-mapping issues discussed above in this PR (with a lot of refactoring around it to make the exporter cleaner overall, even in VHDL). What this means is that you should be able to untrack your changes to the Apologies for seemingly creating merge conflicts every 2 minutes; I'm trying to make all of these core features super robust before I stop supporting the project professionally. |
Over the weekend I have also removed the old backend and moved the "experimental" one to the non-experimental part of the repository, creating more conflicts again, sorry 😢 Resolving them and making your files non-experimentl should be a matter of
|
I just resolved the conflicts, but I still have some problems with the Verilog generation flow. Besides that, I noticed a problem. When testing the
|
Anything I should look at? Do you want to send me steps to reproduce?
This seems like an issue with the Polygeist path. Did you check that the compile script's Polygeist include folder path is pointing to a correct location? |
Thank you! =D I have solved the Verilog generation problem, will let you know if I find anything weird. |
…cmd line parameter passing
Now it looks good on my side, please let me know if anything else needs to be changed =D |
All good on my side! Thanks so much for the huge contribution and apologies for the constant changes of everything 😅 |
This pull request adds the following things:
experimental/data/verilog
. Allmodule_name
,ports_name
, andfile_name
are kept the same.rtl-config-verilog.json
file that contains all the configuration info for Verilog implementations.write_hdl.sh
script to select config file based on the hdl specified by the user.export-rtl
to satisfy Verilog syntax.rtl-cmpi-generator.cpp
to support Verilog syntax when generatingcmpi
unit for Verilog.The results for regression_test are the same as the VHDL backend. Details can be found here: Link.