Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synectic cannot build on non-Windows systems with is-hidden-file installed #510

Closed
nelsonni opened this issue Aug 6, 2021 · 1 comment
Closed
Labels
bug Bug reports or bug fixes dependencies Issues or updates to dependency files

Comments

@nelsonni
Copy link
Member

nelsonni commented Aug 6, 2021

Describe the bug
Attempting to run Synectic with is-hidden-file installed results in the following error:

yarn start
yarn run v1.22.10
$ electron-forge startChecking your systemLocating ApplicationPreparing native dependencies: 0 / 1gyp info find Python using Python version 3.8.2 found at "/Applications/Xcode.app/Contents/Developer/usr/bin/python3"
(node:20340) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
(Use `node --trace-deprecation ...` to show where the warning was created)
gyp info spawn /Applications/Xcode.app/Contents/Developer/usr/bin/python3
gyp info spawn args [
gyp info spawn args   '/Users/nelsonni/Workspace/synectic-2/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/nelsonni/Workspace/synectic-2/node_modules/is-hidden-file/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/nelsonni/Workspace/synectic-2/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/nelsonni/.electron-gyp/13.1.7/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/Users/nelsonni/.electron-gyp/13.1.7',
gyp info spawn args   '-Dnode_gyp_dir=/Users/nelsonni/Workspace/synectic-2/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/Users/nelsonni/.electron-gyp/13.1.7/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/Users/nelsonni/Workspace/synectic-2/node_modules/is-hidden-file',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
⠼ Preparing native dependencies: 0 / 1gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  CXX(target) Release/obj.target/module/src/module.o
../src/module.cc:3:10: fatal error: 'tchar.h' file not found
#include <tchar.h>
         ^~~~~~~~~Preparing native dependencies: 0 / 11 error generated.
make: *** [Release/obj.target/module/src/module.o] Error 1Preparing native dependencies: 0 / 1

An unhandled error has occurred inside Forge:
node-gyp failed to rebuild '/Users/nelsonni/Workspace/synectic-2/node_modules/is-hidden-file'.
Error: `make` failed with exit code: 2


Error: node-gyp failed to rebuild '/Users/nelsonni/Workspace/synectic-2/node_modules/is-hidden-file'.
Error: `make` failed with exit code: 2


    at ModuleRebuilder.rebuildNodeGypModule (/Users/nelsonni/Workspace/synectic-2/node_modules/electron-rebuild/src/module-rebuilder.ts:231:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Rebuilder.rebuildModuleAt (/Users/nelsonni/Workspace/synectic-2/node_modules/electron-rebuild/src/rebuild.ts:283:5)
    at Rebuilder.rebuild (/Users/nelsonni/Workspace/synectic-2/node_modules/electron-rebuild/src/rebuild.ts:189:9)
    at /Users/nelsonni/Workspace/synectic-2/node_modules/@electron-forge/core/src/util/rebuild.ts:33:5
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This error does not appear after running yarn remove is-hidden-file, and based on the error output it appears to be connected with problems running make on the latest version of is-hidden-file.

To Reproduce
Steps to reproduce the behavior:

  1. Run yarn start
  2. Wait for build to reach the Preparing native dependencies stage
  3. See error

Expected behavior
Should compile and run without issue.

Screenshots
image

Versions (please complete the following information):

  • OS: MacOS
  • Synectic Version: 1.0.0-beta (branch: feature/base-rebuild)

Additional context
The missing tchar.h file during the CXX compiling of C/C++ code indicates that this is an issue deep within the compilation process; likely occurring during linking with native code. Per the is-hidden-file documentation:

Windows: Check if file hidden using native code.
So the use of native code might be dependent on the underlying system, which would need to be Windows only in this case.

@nelsonni nelsonni added the bug Bug reports or bug fixes label Aug 6, 2021
@nelsonni nelsonni added this to the v1.0.0 milestone Aug 6, 2021
nelsonni added a commit that referenced this issue Aug 6, 2021
@nelsonni nelsonni modified the milestones: v1.0.0, v1.x.x Jan 31, 2022
@nelsonni nelsonni removed this from the v1.x.x milestone Jun 22, 2022
@nelsonni nelsonni added the dependencies Issues or updates to dependency files label Sep 18, 2022
@nelsonni
Copy link
Member Author

For the same reasoning as #379, this issue is no longer relevant. Synectic no longer require any additional libraries (such as is-hidden-file) to work with git status and filesystem commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports or bug fixes dependencies Issues or updates to dependency files
Projects
None yet
Development

No branches or pull requests

1 participant