Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve hierarchical grouping in branch names for listBranch command #977

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

nelsonni
Copy link
Member

Description:

Update the refPattern in processBranchOutput to group remotes/<remote alias> together and treat all other prefixes that include a slash as a hierarchical grouping in the branch name.

This PR resolves #976, and signifies the following version changes (per Semantic Version):

  • PATCH version increase

Changes:

This PR makes the following changes:

  • Check for remotes/<remote alias to process a remote branch reference, and allow slashes that indicate a hierarchical (directory) structure in the branch name of local branch references.

Checklist:

Before submitting this PR, I have verified that my code:

  • Resides on a fix/ or feature/ branch that was initially branched off from development.
  • Passes code linting (yarn lint) and unit testing (yarn test).
  • Successfully builds a distribution package (yarn package).
  • I have read and am aware of the CONTRIBUTING guide for this project.
  • My name is listed in the Contributors section, or this PR includes a request to add my name.

@nelsonni nelsonni added bug Bug reports or bug fixes feature Feature requests or improvements labels Oct 17, 2022
@nelsonni nelsonni merged commit 29599e9 into main Oct 17, 2022
@nelsonni nelsonni deleted the bugfix/logLocalOnlyBranches branch October 17, 2022 22:35
nelsonni added a commit that referenced this pull request Dec 7, 2022
#977)

* Add unique "key" prop to Directory children (ref: https://epicreact.dev/why-react-needs-a-key-prop/)

* Resolve hierarchical grouping in branch names for `listBranch` command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports or bug fixes feature Feature requests or improvements
Projects
None yet
1 participant