Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quote around $INPUT_PRETTIER_FLAGS to pass flags correctly #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove quote around $INPUT_PRETTIER_FLAGS to pass flags correctly #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@

# if reporter is github-pr-review, run prettier in write mode and report code suggestions
if [ "$INPUT_REPORTER" = "github-pr-review" ]; then
"$(npm root)"/.bin/prettier --write "${INPUT_PRETTIER_FLAGS}" 2>&1 \
# shellcheck disable=SC2086
"$(npm root)"/.bin/prettier --write ${INPUT_PRETTIER_FLAGS} 2>&1 \

Check failure on line 28 in script.sh

View workflow job for this annotation

GitHub Actions / runner / shfmt 

[shfmt] reported by reviewdog 🐶


Raw Output:
script.sh:28:-  "$(npm root)"/.bin/prettier --write ${INPUT_PRETTIER_FLAGS} 2>&1 \
script.sh:29:-  | reviewdog \
script.sh:28:+  "$(npm root)"/.bin/prettier --write ${INPUT_PRETTIER_FLAGS} 2>&1 |
script.sh:29:+    reviewdog \
| reviewdog \
-efm="%E[%trror] %f: %m (%l:%c)" \
-efm="%C[error]%r" \
Expand All @@ -40,7 +41,7 @@
else

# shellcheck disable=SC2086
"$(npm root)"/.bin/prettier --check "${INPUT_PRETTIER_FLAGS}" 2>&1 | sed --regexp-extended 's/(\[warn\].*)$/\1 File is not properly formatted./' \
"$(npm root)"/.bin/prettier --check ${INPUT_PRETTIER_FLAGS} 2>&1 | sed --regexp-extended 's/(\[warn\].*)$/\1 File is not properly formatted./' \

Check failure on line 44 in script.sh

View workflow job for this annotation

GitHub Actions / runner / shfmt 

[shfmt] reported by reviewdog 🐶


Raw Output:
script.sh:44:-  "$(npm root)"/.bin/prettier --check ${INPUT_PRETTIER_FLAGS} 2>&1 | sed --regexp-extended 's/(\[warn\].*)$/\1 File is not properly formatted./' \
script.sh:45:-  | reviewdog \
script.sh:44:+  "$(npm root)"/.bin/prettier --check ${INPUT_PRETTIER_FLAGS} 2>&1 | sed --regexp-extended 's/(\[warn\].*)$/\1 File is not properly formatted./' |
script.sh:45:+    reviewdog \
| reviewdog \
-efm="%-G[warn] Code style issues found in the above file(s). Forgot to run Prettier%. File is not properly formatted." \
-efm="[%tarn] %f %m" \
Expand Down
Loading