Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Commands] Cleanup #instance Command. #1803

Merged
merged 4 commits into from
Nov 22, 2021
Merged

[Commands] Cleanup #instance Command. #1803

merged 4 commits into from
Nov 22, 2021

Conversation

Kinglykrab
Copy link
Contributor

  • Cleanups message and logic.
  • Cleanup ListAllInstances() method.
  • Fix day calculation in ConvertSecondsToTime().

Kinglykrab and others added 4 commits November 21, 2021 18:11
@Kinglykrab
[Commands] Cleanup #instance Command.
953377a 
- Cleanups message and logic.
- Cleanup ListAllInstances() method.
- Fix day calculation in ConvertSecondsToTime().
@Kinglykrab
Cleanup.
71ac246
@Kinglykrab
Add return.
fff4e43
@Kinglykrab
Merge branch 'master' into commnads/instance_cleanup
bcbdb4f
@Kinglykrab Kinglykrab merged commit cece66a into master Nov 22, 2021
@Kinglykrab Kinglykrab deleted the commnads/instance_cleanup branch November 22, 2021 00:02
@Kinglykrab Kinglykrab restored the commnads/instance_cleanup branch November 22, 2021 00:02
@Kinglykrab Kinglykrab deleted the commnads/instance_cleanup branch November 22, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splose splose splose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kinglykrab @splose