[Tasks] Place task item rewards in free slots #2300
Conversation
Live places item rewards into the first free inventory slot and only places it on the cursor if inventory is full
Akkadius
changed the title
|
Tasks should actually be using the Client::QuestReward stuff. |
|
Live doesn't use the QuestReward packet for task rewards. It does use the separate CashReward packet for money rewards though (I don't think emu has this implemented right now) |
Did they change it on live? I know live has 2 different reward systems hooked up into the task system and completing a task always did the quest ding (which is why we have the SendSound call at the end, which is just QuestReward ...) |
|
Possibly, doing a DoN solo progression quest and a shared task mission (old style rewards) both didn't play a sound and didn't use the quest reward packet though. |
|
Talking in private with @hgtw it does appear they sometimes do use QuestRewards and sometimes don't. Thanks SOE :P They also use OP_CashRewards for cash rewards. |
Live places item rewards into the first free inventory slot and only places it on the cursor if inventory is full
This reverts the changes until an alternative method can be found to properly place rewards in inventory since this doesn't auto stack items Revert "[Tasks] Let task reward find free bag slots (EQEmu#2431)" This reverts commit b4e46c1. Revert "[Tasks] Place task item rewards in free slots (EQEmu#2300)" This reverts commit f381453.
Live places item rewards into the first free inventory slot and only places it on the cursor if inventory is full
Live places item rewards into the first free inventory slot and only
places it on the cursor if inventory is full
This was more of a pet peeve than a critical fix, but it's parity with live