[Revert] Placing task rewards in free slots #2450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the changes until an alternative method can be found to properly place rewards in inventory since this doesn't auto stack items Revert "[Tasks] Let task reward find free bag slots (EQEmu#2431)" This reverts commit b4e46c1. Revert "[Tasks] Place task item rewards in free slots (EQEmu#2300)" This reverts commit f381453.
Kinglykrab
changed the title
Kinglykrab
approved these changes
Sep 26, 2022
|
Would be nice to not step backwards with this one since this is actually a really nice change (thanks @hgtw) I put up a change here in our branch 2f6f325 #2449 Below is a GIF of Long bow is getting added every task completion, iron ration is properly stacking
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes until an alternative method can be found to properly place rewards in inventory since this doesn't auto stack items
Revert "[Tasks] Let task reward find free bag slots (#2431)"
This reverts commit b4e46c1.
Revert "[Tasks] Place task item rewards in free slots (#2300)"
This reverts commit f381453.
This will probably need to use something like
AutoPutLootInInventoryor something but I'm not familiar with the inventory api and don't want to look into an alternative right now.