Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merchants] Change database structure for merchant slots #3974

Merged
merged 2 commits into from Jan 14, 2024

Conversation

joligario
Copy link
Contributor

The slot field should be unsigned int. The temp slot is currently limited to 127. The client will limit the visible slots. Fixes selling to merchants with inventory >127 as seen in:
[**QueryErr**] **Zone** [**poknowledge**] MySQL Error (1264) [Out of range value for column 'slot' at row 1] Query [REPLACE INTO merchantlist_temp (npcid, slot, zone_id, instance_id, itemid, charges) VALUES(202173, 311, 202, 0, 26708, 1)]

image

image

The `slot` field should be unsigned int. The temp slot is currently limited to 127. The client will limit the visible slots.
@joligario
Copy link
Contributor Author

image

image

image

@Kinglykrab Kinglykrab merged commit e40267b into master Jan 14, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the merchantlists-slots branch January 14, 2024 01:58
@Akkadius Akkadius mentioned this pull request Jan 14, 2024
Kinglykrab added a commit that referenced this pull request Jan 25, 2024
### Bots

* ^mez command spell list fix ([#3998](#3998)) @dariusuknuis 2024-01-19

### Code

* Cleanup position methods ([#4015](#4015)) @Kinglykrab 2024-01-25

### Commands

* Add `#npcedit set_grid [Grid ID]` to `#npcedit` ([#4004](#4004)) @Kinglykrab 2024-01-22

### Crash Fix

* Fix crash when creating Frogloks/Drakkin ([#4016](#4016)) @Kinglykrab 2024-01-25
* Reverting PR #3877 ([#3997](#3997)) @fryguy503 2024-01-17

### Database

* Drop deprecated item_tick table ([#3977](#3977)) @Akkadius 2024-01-14
* Drop item_tick if exists tweak in manifest ([#3985](#3985)) @Akkadius 2024-01-15
* Increase max spawngroup name from 50 to 200 ([#3991](#3991)) @Akkadius 2024-01-22

### Fixes

* Fix Mercenaries Buffs/Zoning Issues ([#4000](#4000)) @Kinglykrab 2024-01-22
* Fix zone database update manifest ([#3972](#3972)) @Kinglykrab 2024-01-13
* Fixes to zone idle while empty changes. ([#4006](#4006)) @noudess 2024-01-23
* Reversed logic on InLiquid ([#3979](#3979)) @fryguy503 2024-01-14

### Instances

* Convert Instance Quest Methods to Repositories ([#4012](#4012)) @Kinglykrab 2024-01-25

### Logging

* Force Info category to be always on in file/console logs ([#3990](#3990)) @Akkadius 2024-01-22

### Merchants

* Change database structure for merchant slots ([#3974](#3974)) @joligario 2024-01-14

### Messages

* Fix disciple message added by previous patch. ([#3986](#3986)) @noudess 2024-01-15

### Quest API

* QuestReward should now summon item to the inventory instead of the cursor. ([#3996](#3996)) @regneq 2024-01-22

### Repositories

* Add `rank` to reserved words ([#3982](#3982)) @Akkadius 2024-01-15
* Fix datetime zero-value save behavior ([#3976](#3976)) @Akkadius 2024-01-14

### Spawn2

* Spawn condition value should default spawn_conditions value ([#3980](#3980)) @noudess 2024-01-14

### Zoning

* Additional logs for zoning under instance checks ([#3989](#3989)) @Akkadius 2024-01-22
@Kinglykrab Kinglykrab mentioned this pull request Jan 25, 2024
Akkadius pushed a commit that referenced this pull request Jan 25, 2024
### Bots

* ^mez command spell list fix ([#3998](#3998)) @dariusuknuis 2024-01-19

### Code

* Cleanup position methods ([#4015](#4015)) @Kinglykrab 2024-01-25

### Commands

* Add `#npcedit set_grid [Grid ID]` to `#npcedit` ([#4004](#4004)) @Kinglykrab 2024-01-22

### Crash Fix

* Fix crash when creating Frogloks/Drakkin ([#4016](#4016)) @Kinglykrab 2024-01-25
* Reverting PR #3877 ([#3997](#3997)) @fryguy503 2024-01-17

### Database

* Drop deprecated item_tick table ([#3977](#3977)) @Akkadius 2024-01-14
* Drop item_tick if exists tweak in manifest ([#3985](#3985)) @Akkadius 2024-01-15
* Increase max spawngroup name from 50 to 200 ([#3991](#3991)) @Akkadius 2024-01-22

### Fixes

* Fix Mercenaries Buffs/Zoning Issues ([#4000](#4000)) @Kinglykrab 2024-01-22
* Fix zone database update manifest ([#3972](#3972)) @Kinglykrab 2024-01-13
* Fixes to zone idle while empty changes. ([#4006](#4006)) @noudess 2024-01-23
* Reversed logic on InLiquid ([#3979](#3979)) @fryguy503 2024-01-14

### Instances

* Convert Instance Quest Methods to Repositories ([#4012](#4012)) @Kinglykrab 2024-01-25

### Logging

* Force Info category to be always on in file/console logs ([#3990](#3990)) @Akkadius 2024-01-22

### Merchants

* Change database structure for merchant slots ([#3974](#3974)) @joligario 2024-01-14

### Messages

* Fix disciple message added by previous patch. ([#3986](#3986)) @noudess 2024-01-15

### Quest API

* QuestReward should now summon item to the inventory instead of the cursor. ([#3996](#3996)) @regneq 2024-01-22

### Repositories

* Add `rank` to reserved words ([#3982](#3982)) @Akkadius 2024-01-15
* Fix datetime zero-value save behavior ([#3976](#3976)) @Akkadius 2024-01-14

### Spawn2

* Spawn condition value should default spawn_conditions value ([#3980](#3980)) @noudess 2024-01-14

### Zoning

* Additional logs for zoning under instance checks ([#3989](#3989)) @Akkadius 2024-01-22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants