[Bug Fix] Fixes to zone idle while empty changes. #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinglykrab
approved these changes
Jan 23, 2024
Kinglykrab
added a commit
that referenced
this pull request
Jan 25, 2024
### Bots * ^mez command spell list fix ([#3998](#3998)) @dariusuknuis 2024-01-19 ### Code * Cleanup position methods ([#4015](#4015)) @Kinglykrab 2024-01-25 ### Commands * Add `#npcedit set_grid [Grid ID]` to `#npcedit` ([#4004](#4004)) @Kinglykrab 2024-01-22 ### Crash Fix * Fix crash when creating Frogloks/Drakkin ([#4016](#4016)) @Kinglykrab 2024-01-25 * Reverting PR #3877 ([#3997](#3997)) @fryguy503 2024-01-17 ### Database * Drop deprecated item_tick table ([#3977](#3977)) @Akkadius 2024-01-14 * Drop item_tick if exists tweak in manifest ([#3985](#3985)) @Akkadius 2024-01-15 * Increase max spawngroup name from 50 to 200 ([#3991](#3991)) @Akkadius 2024-01-22 ### Fixes * Fix Mercenaries Buffs/Zoning Issues ([#4000](#4000)) @Kinglykrab 2024-01-22 * Fix zone database update manifest ([#3972](#3972)) @Kinglykrab 2024-01-13 * Fixes to zone idle while empty changes. ([#4006](#4006)) @noudess 2024-01-23 * Reversed logic on InLiquid ([#3979](#3979)) @fryguy503 2024-01-14 ### Instances * Convert Instance Quest Methods to Repositories ([#4012](#4012)) @Kinglykrab 2024-01-25 ### Logging * Force Info category to be always on in file/console logs ([#3990](#3990)) @Akkadius 2024-01-22 ### Merchants * Change database structure for merchant slots ([#3974](#3974)) @joligario 2024-01-14 ### Messages * Fix disciple message added by previous patch. ([#3986](#3986)) @noudess 2024-01-15 ### Quest API * QuestReward should now summon item to the inventory instead of the cursor. ([#3996](#3996)) @regneq 2024-01-22 ### Repositories * Add `rank` to reserved words ([#3982](#3982)) @Akkadius 2024-01-15 * Fix datetime zero-value save behavior ([#3976](#3976)) @Akkadius 2024-01-14 ### Spawn2 * Spawn condition value should default spawn_conditions value ([#3980](#3980)) @noudess 2024-01-14 ### Zoning * Additional logs for zoning under instance checks ([#3989](#3989)) @Akkadius 2024-01-22
Merged
Akkadius
pushed a commit
that referenced
this pull request
Jan 25, 2024
### Bots * ^mez command spell list fix ([#3998](#3998)) @dariusuknuis 2024-01-19 ### Code * Cleanup position methods ([#4015](#4015)) @Kinglykrab 2024-01-25 ### Commands * Add `#npcedit set_grid [Grid ID]` to `#npcedit` ([#4004](#4004)) @Kinglykrab 2024-01-22 ### Crash Fix * Fix crash when creating Frogloks/Drakkin ([#4016](#4016)) @Kinglykrab 2024-01-25 * Reverting PR #3877 ([#3997](#3997)) @fryguy503 2024-01-17 ### Database * Drop deprecated item_tick table ([#3977](#3977)) @Akkadius 2024-01-14 * Drop item_tick if exists tweak in manifest ([#3985](#3985)) @Akkadius 2024-01-15 * Increase max spawngroup name from 50 to 200 ([#3991](#3991)) @Akkadius 2024-01-22 ### Fixes * Fix Mercenaries Buffs/Zoning Issues ([#4000](#4000)) @Kinglykrab 2024-01-22 * Fix zone database update manifest ([#3972](#3972)) @Kinglykrab 2024-01-13 * Fixes to zone idle while empty changes. ([#4006](#4006)) @noudess 2024-01-23 * Reversed logic on InLiquid ([#3979](#3979)) @fryguy503 2024-01-14 ### Instances * Convert Instance Quest Methods to Repositories ([#4012](#4012)) @Kinglykrab 2024-01-25 ### Logging * Force Info category to be always on in file/console logs ([#3990](#3990)) @Akkadius 2024-01-22 ### Merchants * Change database structure for merchant slots ([#3974](#3974)) @joligario 2024-01-14 ### Messages * Fix disciple message added by previous patch. ([#3986](#3986)) @noudess 2024-01-15 ### Quest API * QuestReward should now summon item to the inventory instead of the cursor. ([#3996](#3996)) @regneq 2024-01-22 ### Repositories * Add `rank` to reserved words ([#3982](#3982)) @Akkadius 2024-01-15 * Fix datetime zero-value save behavior ([#3976](#3976)) @Akkadius 2024-01-14 ### Spawn2 * Spawn condition value should default spawn_conditions value ([#3980](#3980)) @noudess 2024-01-14 ### Zoning * Additional logs for zoning under instance checks ([#3989](#3989)) @Akkadius 2024-01-22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where zones would stay active after an idle timer expired. This was an unintended side effect of PR 3891.
Changes as follows:
One note. Quests that use processmobswhilezoneempty() used to be able to assume that they could turn the zone back off. If anyone else uses this quest function, those quests will need to check/save the idle status of the zone before mucking with it, then restore it. This wasn't needed before PT 3891 because zones were always idle when empty. If people want, I'll do a second PR making the quest override a separate value, so it doesnt mess with the zone one.