Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format-checkers regex #97

Merged
merged 2 commits into from
May 13, 2024
Merged

fix: format-checkers regex #97

merged 2 commits into from
May 13, 2024

Conversation

Purexo
Copy link
Contributor

@Purexo Purexo commented May 13, 2024

need to support :emoji: format

  • fix invalid regex
    image
  • add some unit tests
  • change FunctionChecker type use string instead Message for testing, all checks use cleanContent from Message

@Purexo Purexo requested review from targos and Xstoudi May 13, 2024 15:15
@Purexo Purexo force-pushed the fix/link-format branch 2 times, most recently from 79475e9 to 980be41 Compare May 13, 2024 15:20
need to support `:emoji:` format

* fix invalid regex https://github.com/ES-Community/bot/assets/5005154/02494c78-25d3-4a80-be93-77309e211816
* add some unit tests
* change `FunctionChecker` type
  use string instead Message for testing, all checks use `cleanContent` from `Message`
@Purexo Purexo merged commit b5fc4ee into main May 13, 2024
2 checks passed
@Purexo Purexo deleted the fix/link-format branch May 13, 2024 16:08
@Xstoudi Xstoudi mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants