Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndep changes are causing failures in CESM testing #790

Closed
cacraigucar opened this issue Apr 18, 2023 · 2 comments
Closed

ndep changes are causing failures in CESM testing #790

cacraigucar opened this issue Apr 18, 2023 · 2 comments
Assignees
@jtruesdal
Labels
bug Something isn't working correctly

Comments

@cacraigucar
Copy link
Collaborator

What happened?

According to @fischer-ncar the following two tests failed regression testing:

FAIL IRT_C3_Ld7.f19_g17.BHIST.cheyenne_intel.allactive-defaultio RUN time=7225
1152:  ERROR finding ndep_stream_nl namelistERROR in atm_stream_ndep.F90 at line 95
1152:Image          PC            Routine        Line    Source        
1152:cesm.exe       0000000003A4EA96  Unknown           Unknown  Unknown
1152:cesm.exe       000000000367B540  shr_abort_mod_mp_     114  shr_abort_mod.F90
1152:cesm.exe       000000000058BF44  atm_stream_ndep_m      95  atm_stream_ndep.F90
1152:cesm.exe       0000000000589C0F  atm_import_export    1078  atm_import_export.F90
1152:cesm.exe       0000000000577D87  atm_comp_nuopc_mp     754  atm_comp_nuopc.F90

FAIL SMS_C2_Ln9_Vnuopc.f19_f19_mg17.FXHIST.cheyenne_intel.cam-outfrq9s RUN time=1820
144: ERROR:
144:  ERROR finding ndep_stream_nl namelistERROR in atm_stream_ndep.F90 at line 95
144:Image          PC            Routine        Line    Source        
144:cesm.exe       000000000398F5A6  Unknown           Unknown  Unknown
144:cesm.exe       00000000035D0697  shr_abort_mod_mp_     114  shr_abort_mod.F90
144:cesm.exe       0000000000586565  atm_stream_ndep_m      95  atm_stream_ndep.F90
144:cesm.exe       000000000058420F  atm_import_export    1078  atm_import_export.F90
144:cesm.exe       00000000005725E3  atm_comp_nuopc_mp     754  atm_comp_nuopc.F90

The fix according to @jedwards4b:

The issue is at line 87 of file atm_stream_ndep.F90
      open( newunit=nu_nml, file='atm_in', status='old', iostat=nml_error )

should be
       filein = "atm_in" // trim(inst_suffix)
      open( newunit=nu_nml, file=filein, status='old', iostat=nml_error )

Where inst_suffix is from:
 use cam_instance,     only: inst_suffix

@brian-eaton suggested the following check:
While we're at it we should check the iostat return from the open command. That would have immediately pointed Chris to the culprit.

What are the steps to reproduce the bug?

Run the reported regression test

What CAM tag were you using?

cam6_3_106

What machine were you running CAM on?

CISL machine (e.g. cheyenne)

What compiler were you using?

Intel

Path to a case directory, if applicable

No response

Will you be addressing this bug yourself?

Any CAM SE can do this

Extra info

No response
@cacraigucar cacraigucar added the bug Something isn't working correctly label Apr 18, 2023
@jtruesdal
Copy link
Collaborator

I will add the fix to PR #761. modified code:

   use cam_instance     , only: inst_suffix
    ...
   filein = "atm_in" // trim(inst_suffix)
   open( newunit=nu_nml, file=filein, status='old', iostat=nml_error )
   if (nml_error /= 0) then
      call endrun(subName': ERROR opening '//trim(filein)//errMsg(sourcefile, __LINE__))
   end if

@jedwards4b
Copy link

Looks good, thank you.

@jtruesdal jtruesdal mentioned this issue Apr 18, 2023
Merged
@kdraeder kdraeder mentioned this issue Apr 26, 2023
Closed
jtruesdal added a commit that referenced this issue Apr 28, 2023
@jtruesdal
Merge pull request #761 from jtruesdal/ebudget_dev_update
962921a 
cam6_3_109: Science and infrastructure changes to improve energy/mass budget reporting and closure.

Add inline energy/mass budgets support. (#519) Science changes are included that help close the mass and energy budgets of physics and the SE/MPAS dycores (#521) as well as adding all water constituents to atmospheric mass (pressure) (#520). Lastly a small fix for issue #790.

We've been testing with an interim CTSM branch that has MPAS land boundary condition files. There is a parallel PR ESCOMP/CTSM#1501 to get these updated MPAS files into the land repo.

As of this PR energy/mass budgets have been added for physics and the SE and MPAS dycores. The work of budget improvement, expansion to other supported dycores, and refactor of the logging infrastructure will continue in future PRs.
Most functional regression testing are passing and baselines are expected to fail due to the climate changing science updates.

Similar to amwg_diagnostic functionality, energy/mass budget diagnostic fields will be added to a history file via the thermo_budget_histfile_num namelist parameter. Globally averaged energy budget summaries are also calculated and written to the atm log file every time the budget history tape is written to. The period over which energy and mass budgets are averaged is the same as the averaging period of the history budget file. Thus history budgets can be output/averaged at time step, hour, or month resolutions using the nhtfrq variable specific to the budget history file identified by (.false.) The default is .false. (no budgeting) because of the global gathers needed to create the budgets.

closes #790
closes #519
closes #520
closes #521
closes #789
@github-project-automation github-project-automation bot moved this from To Do to Done in CAM Development Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtruesdal jtruesdal

Labels
bug Something isn't working correctly
Projects
CAM Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jedwards4b @jtruesdal @cacraigucar @nusbaume