cam_cesm2_1_rel_57: Transport CL and Br when mid-atmos chem is used in cesm2.1 #435
Conversation
modified: sd_waccm_ma_cam6.xml
modified: sd_waccm_mad_cam6.xml
modified: waccm_ma_hist_cam6.xml
test/system/test_driver.sh
Outdated
| @@ -937,7 +937,7 @@ if [ -n "${submit_script_cb}" ]; then | |||
| case $hostname in | |||
| # cheyenne | |||
| chey* | r* ) | |||
| batch_queue_submit='qsub ' | |||
| batch_queue_submit='qsub -V ' | |||
There was a problem hiding this comment.
@cacraigucar I need to include the -V for cheyenne. Otherwise, the stand-alone cam tests don't work correctly.
There was a problem hiding this comment.
Just curious - what changed since you last made a CESM2_1 branch tag back in September, do you know?
There was a problem hiding this comment.
I needed the same changes for the cam_cesm2_1_rel_56 also. I just did not include the changes to test_driver.sh in the tag.
There was a problem hiding this comment.
In that case, I wholeheartedly approve this change. I'm not surprised that there are changes like this needed for the branch which is so old.
There was a problem hiding this comment.
@cacraigucar I need to include the
-Vfor cheyenne. Otherwise, the stand-alone cam tests don't work correctly.
To me, this sounds like an error in the submit script. Any environmental variables from test driver that are not resolved in the script (i.e., the environmental variable is still there) should be evaluated before being written to the script. For example, if the script depends on variable, FOO:
export FOO=bar
then we should not see $FOO or ${FOO} in the script, we should see bar.
I think it is a lot more robust to do this rather than depend on the environment. Thoughts?
There was a problem hiding this comment.
@gold2718 You make a good point. Given that this is for a machine that does not have much life left and for a branch that has very little development activity, I prefer to go with my simple fix. I don't want to spend any more time on this.
@cacraigucar @nusbaume Thoughts?
There was a problem hiding this comment.
If it is not fixed now, I suggest opening an issue to get this fixed.
There was a problem hiding this comment.
Given that we are under a HARD deadline before the PGI compiler goes "poof", I would vote to just make this an issue and not fix it here. We can then fix it whenever we replace the PGI tests with GNU, or if/when we port this branch to Derecho (whichever comes first).
There was a problem hiding this comment.
I agree to move ahead with this and @fvitt can open an issue detailing what he saw.
cacraigucar
changed the title
Remove CL and BR from the not-transported lists in middle-atmosphere chemistry mechanisms.
Addresses #314 for CESM2.1