-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_3_056: Update externals to support CICE6 #581
Conversation
Update cam_development branch
modified: Externals.cfg
modified: cime_config/testdefs/testlist_cam.xml new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg2_default/shell_commands renamed: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_casper/user_nl_cam -> cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg2_default/user_nl_cam renamed: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_casper/user_nl_clm -> cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg2_default/user_nl_clm renamed: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_casper/shell_commands -> cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_default/shell_commands new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_default/user_nl_cam new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_default/user_nl_clm new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_nondefault/shell_commands new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_nondefault/user_nl_cam new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_nondefault/user_nl_clm new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_pcols1536/shell_commands new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_pcols1536/user_nl_cam new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_pcols1536/user_nl_clm
modified: test/system/test_driver.sh
Externals.cfg
Outdated
@@ -1,24 +1,24 @@ | |||
[ccs_config] | |||
tag = ccs_config_cesm0.0.18 | |||
tag = ccs_config_cesm0.0.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GPU PR (#577) has this going to 23. Could that be a possibility for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed! I'll run a few tests to make sure it doesn't break anything crazy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating to ccs_config_cesm0.0.23 did not break anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few notes on the ChangeLog
Originator(s): peverwhee | ||
Date: | ||
One-line Summary: Update externals to match cesm2_3_alpha09a tag | ||
Github PR URL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github PR URL: | |
Github PR URL: https://github.com/ESCOMP/CAM/pull/581 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Purpose of changes (include the issue number and title text for each relevant GitHub issue): | ||
- Update to cesm2_3_alpha09a externals (https://github.com/ESCOMP/CAM/issues/565) | ||
|
||
Describe any changes made to build system: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sure you are not skipping anything, please label each section with no changes with an NA (or some other indication). For example:
Describe any changes made to build system: | |
Describe any changes made to build system: NA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
List all existing files that have been modified, and describe the changes: | ||
M Externals.cfg | ||
- update to match cesm2_3_alpha09a tag: | ||
- EXCEPTIONS: CMEPS and CDEPS have more recent tags than the alpha tag due to nuopc issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an exception for ccs_config_cesm if the update to 0.0.23 works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
- update to match cesm2_3_alpha09a tag: | ||
- EXCEPTIONS: CMEPS and CDEPS have more recent tags than the alpha tag due to nuopc issues | ||
M cime_config/testdefs/testlist_cam.xml | ||
- use longname for compsets tested with MCT that use CICE since CICE6 doesn't have a nuopc cap: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean mct.
- use longname for compsets tested with MCT that use CICE since CICE6 doesn't have a nuopc cap: | |
- use longname for compsets tested with MCT that use CICE since CICE6 doesn't have an mct cap: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed i did. Fixed.
modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg2_default/shell_commands modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_default/shell_commands modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_nondefault/shell_commands modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_pcols1536/shell_commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@peverwhee - Has this tag morphed into matching cesm2_3_alpha09b? If so, please rename the title. |
@cacraigucar I don't believe so. It definitely is closer to what alpha09b will likely be, but I don't think the updates for 09b are set in stone yet? |
@peverwhee - Perhaps since it may not match either external, we just change the title to be something like "Update externals to support CICE6"? |
alpha09b isn't set in stone yet. But the biggest change in alpha09b is the python package reorganization in cime6.0.17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming... The only test which is now currently failing is the DAE test which has been failing for quite some time, correct?
@cacraigucar That is correct. I have updated the PR description accordingly. |
Merge pull request ESCOMP#581 from peverwhee/cice_updates
Updates
Testing
There are baseline and namelist changes due to the Externals changes but otherwise the only failing test is the existing DAE failure
closes #565
closes #512
closes #566
closes #573
closes #577
closes #583
closes #532
closes #559