Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_3_056: Update externals to support CICE6 #581

Merged
merged 18 commits into from
Apr 30, 2022

Conversation

peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Apr 22, 2022

Updates

  • Externals.cfg updated to match externals in cesm2_3_alpha09a (EXCEPT: CMEPS and CDEPS have more recent tags with nuopc-related fixes. Also, ccs_config_cesm has a later tag to support GPUs and fix CICE6-related error)
  • testlist_cam.xml updated to use longnames for MCT tests of the following compsets (the ones that have a CICE component; CICE6 does not have a NUOPC cap, so we have to explicitly use CICE5 for these tests): F2000climo, FHIST, FSCAM, FW1850

Testing

There are baseline and namelist changes due to the Externals changes but otherwise the only failing test is the existing DAE failure

closes #565
closes #512
closes #566
closes #573
closes #577
closes #583
closes #532
closes #559

Mariana Vertenstein and others added 8 commits April 13, 2022 09:00
Update cam_development branch
	modified:   cime_config/testdefs/testlist_cam.xml
	new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg2_default/shell_commands
	renamed:    cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_casper/user_nl_cam -> cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg2_default/user_nl_cam
	renamed:    cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_casper/user_nl_clm -> cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg2_default/user_nl_clm
	renamed:    cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_casper/shell_commands -> cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_default/shell_commands
	new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_default/user_nl_cam
	new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_default/user_nl_clm
	new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_nondefault/shell_commands
	new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_nondefault/user_nl_cam
	new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_nondefault/user_nl_clm
	new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_pcols1536/shell_commands
	new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_pcols1536/user_nl_cam
	new file:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_pcols1536/user_nl_clm
	modified:   test/system/test_driver.sh
@peverwhee peverwhee added this to the CAM7dev milestone Apr 22, 2022
@peverwhee peverwhee self-assigned this Apr 22, 2022
cime_config/testdefs/testlist_cam.xml Show resolved Hide resolved
Externals.cfg Outdated
@@ -1,24 +1,24 @@
[ccs_config]
tag = ccs_config_cesm0.0.18
tag = ccs_config_cesm0.0.21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GPU PR (#577) has this going to 23. Could that be a possibility for this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed! I'll run a few tests to make sure it doesn't break anything crazy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating to ccs_config_cesm0.0.23 did not break anything

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few notes on the ChangeLog

Originator(s): peverwhee
Date:
One-line Summary: Update externals to match cesm2_3_alpha09a tag
Github PR URL:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Github PR URL:
Github PR URL: https://github.com/ESCOMP/CAM/pull/581

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Purpose of changes (include the issue number and title text for each relevant GitHub issue):
- Update to cesm2_3_alpha09a externals (https://github.com/ESCOMP/CAM/issues/565)

Describe any changes made to build system:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure you are not skipping anything, please label each section with no changes with an NA (or some other indication). For example:

Suggested change
Describe any changes made to build system:
Describe any changes made to build system: NA

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

List all existing files that have been modified, and describe the changes:
M Externals.cfg
- update to match cesm2_3_alpha09a tag:
- EXCEPTIONS: CMEPS and CDEPS have more recent tags than the alpha tag due to nuopc issues
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an exception for ccs_config_cesm if the update to 0.0.23 works.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

- update to match cesm2_3_alpha09a tag:
- EXCEPTIONS: CMEPS and CDEPS have more recent tags than the alpha tag due to nuopc issues
M cime_config/testdefs/testlist_cam.xml
- use longname for compsets tested with MCT that use CICE since CICE6 doesn't have a nuopc cap:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean mct.

Suggested change
- use longname for compsets tested with MCT that use CICE since CICE6 doesn't have a nuopc cap:
- use longname for compsets tested with MCT that use CICE since CICE6 doesn't have an mct cap:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed i did. Fixed.

@cacraigucar cacraigucar changed the title Update externals to match cesm2_3_alpha09a tag cam6_3_056: Update externals to match cesm2_3_alpha09a tag Apr 22, 2022
	modified:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg2_default/shell_commands
	modified:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_default/shell_commands
	modified:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_nondefault/shell_commands
	modified:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_mg3_pcols1536/shell_commands
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cacraigucar cacraigucar changed the title cam6_3_056: Update externals to match cesm2_3_alpha09a tag Update externals to match cesm2_3_alpha09a tag Apr 25, 2022
@cacraigucar cacraigucar changed the title Update externals to match cesm2_3_alpha09a tag cam6_3_056: Update externals to match cesm2_3_alpha09a tag Apr 29, 2022
@cacraigucar
Copy link
Collaborator

@peverwhee - Has this tag morphed into matching cesm2_3_alpha09b? If so, please rename the title.

@peverwhee
Copy link
Collaborator Author

@cacraigucar I don't believe so. It definitely is closer to what alpha09b will likely be, but I don't think the updates for 09b are set in stone yet?

@cacraigucar
Copy link
Collaborator

@peverwhee - Perhaps since it may not match either external, we just change the title to be something like "Update externals to support CICE6"?

@fischer-ncar
Copy link
Collaborator

alpha09b isn't set in stone yet. But the biggest change in alpha09b is the python package reorganization in cime6.0.17.
I think the other plan for alpha09b is to get scam working. So in the end, this may end up matching alpha9b. Or maybe
alpha09b will look like cam6_3_056.

@peverwhee peverwhee changed the title cam6_3_056: Update externals to match cesm2_3_alpha09a tag cam6_3_056: Update externals to support CICE6 Apr 29, 2022
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming... The only test which is now currently failing is the DAE test which has been failing for quite some time, correct?

@peverwhee
Copy link
Collaborator Author

@cacraigucar That is correct. I have updated the PR description accordingly.

@peverwhee peverwhee merged commit 47ffbf2 into ESCOMP:cam_development Apr 30, 2022
cacraigucar added a commit to cacraigucar/CAM that referenced this pull request May 2, 2022
Merge pull request ESCOMP#581 from peverwhee/cice_updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

7 participants