-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first_year and last_year in stream definition should be more general #62
Comments
I did some testing that suggests that first_year and last_year are currently required for the list of stream files to be created correctly. This seems to be the responsible code: CDEPS/cime_config/stream_cdeps.py Lines 101 to 111 in 9f54ef0
My initial thought on how to resolve this is:
I haven't tested this. |
This is related somewhat to #82. @billsacks we should likely discussion this more... |
* Adapt docn_datamode_cplhist for dice_datamode_cplhist * Fix .or. and local variables have different names in docn and dice * Add Si_imask. Decide whether to have flds_i2o_per_cat for cplhist method. * Copy sea ice stream fields to export state fields via dshr_dfield_add * Switches So_t from C to K. Decide on which/add switch * Overwrite missing value of 0 K in Si_t * Handle So_t in C and K in docn_datamode_cplhist_mod.F90 Need model SST to be in K if (minval(So_t) .LT. 100.0_r8), convert C-->K * Only fill docn_datamode_cplhist export variables if associated. Handle units of So_t based on namelist input * Default convert SST C to K (as currently). Then switch based on optional sst_constant_value * Allow null return for taux too in dice/dice_datamode_cplhist_mod.F90 * Add doc for dice cplhist mode to dice.rst
I noticed that many (all?) of the stream_definition xml files define a first_year and last_year like this:
https://github.com/billsacks/CDEPS/blob/48a26e6e39a0a1dbfca506192fab089344f49725/datm/cime_config/stream_definition_datm.xml#L206
I see two problems with this:
A simple fix is to expand these years to have a ridiculously huge range, as I did in 48a26e6
I think a cleaner fix would involve making first_year and last_year optional here. From a quick glance through the code that parses this, it looks like these may currently be required.
The text was updated successfully, but these errors were encountered: