Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max daylength doesn't change over time for varying orbital parameters #260

Closed
billsacks opened this issue Feb 8, 2018 · 1 comment
Closed

max daylength doesn't change over time for varying orbital parameters #260

billsacks opened this issue Feb 8, 2018 · 1 comment
Assignees
@billsacks
Labels
bug something is working incorrectly priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Milestone
cesm2

Comments

@billsacks
Copy link
Member

As documented in #19 , @ekluzek recently changed the max daylength function so that it is set properly based on the starting orbital parameters for a run. However, this still doesn't change over time, if running with time-varying orbital parameters.
@billsacks billsacks added type: bug priority: low Background task that doesn't need to be done right away. labels Feb 8, 2018
@billsacks billsacks mentioned this issue Feb 8, 2018
Closed
@billsacks billsacks added severity: critical and removed priority: low Background task that doesn't need to be done right away. labels May 15, 2018
@billsacks billsacks self-assigned this May 15, 2018
@billsacks billsacks added this to the cesm2 milestone May 15, 2018
@billsacks
Copy link
Member Author

billsacks commented May 15, 2018 •
edited
Loading

Turns out this one is important (because now variable_years is the default for HIST runs)!

@billsacks billsacks added bug something is working incorrectly priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations and removed severity: critical bug something is working incorrectly labels May 15, 2018
@billsacks billsacks mentioned this issue May 15, 2018
Closed
billsacks added a commit to billsacks/ctsm that referenced this issue May 16, 2018
@billsacks
Update max day length (max_dayl) each time step
1f48ede 
This is needed for max day length to remain correct with time-varying
orbital parameters, which in turn is needed to achieve exact restart
in a run that crosses the year boundary with time-varying orbital
parameters.

Fixes ESCOMP#379
Fixes ESCOMP#260
@billsacks billsacks mentioned this issue May 16, 2018
Merged
billsacks added a commit that referenced this issue May 17, 2018
@billsacks
Merge branch 'max_dayl_varorb'
e739c2c 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes #379
Fixes #260
ekluzek added a commit that referenced this issue May 18, 2018
@ekluzek
Merge tag 'clm5.0.dev012' into release-clm5.0
db586e2 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes #379
Fixes #260
ekluzek added a commit to ekluzek/CTSM that referenced this issue May 22, 2018
@ekluzek
Merge tag 'clm5.0.dev012' into fincleanup
df9c1a6 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
katiedagon added a commit to katiedagon/ctsm that referenced this issue May 30, 2018
@katiedagon
Merge tag 'clm5.0.dev012' into ParamEns
15ebb27 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
billsacks added a commit to billsacks/ctsm that referenced this issue Feb 22, 2019
@billsacks
Update max day length (max_dayl) each time step
24e08d3 
This is needed for max day length to remain correct with time-varying
orbital parameters, which in turn is needed to achieve exact restart
in a run that crosses the year boundary with time-varying orbital
parameters.

Fixes ESCOMP#379
Fixes ESCOMP#260
billsacks added a commit to billsacks/ctsm that referenced this issue Feb 22, 2019
@billsacks
Merge branch 'max_dayl_varorb'
34cbff8 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
billsacks pushed a commit to billsacks/ctsm that referenced this issue Feb 22, 2019
@ekluzek
Merge tag 'clm5.0.dev012' into fincleanup
7782897 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@billsacks
Update max day length (max_dayl) each time step
044bae8 
This is needed for max day length to remain correct with time-varying
orbital parameters, which in turn is needed to achieve exact restart
in a run that crosses the year boundary with time-varying orbital
parameters.

Fixes ESCOMP#379
Fixes ESCOMP#260
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@billsacks
Merge branch 'max_dayl_varorb'
635de1f 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@ekluzek
Merge tag 'clm5.0.dev012' into release-clm5.0
ebdfa57 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
@ekluzek
Merge tag 'clm5.0.dev012' into fincleanup
2d0d7d5 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jul 5, 2024
@billsacks
Update max day length (max_dayl) each time step
25c8e98 
This is needed for max day length to remain correct with time-varying
orbital parameters, which in turn is needed to achieve exact restart
in a run that crosses the year boundary with time-varying orbital
parameters.

Fixes ESCOMP#379
Fixes ESCOMP#260
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jul 5, 2024
@billsacks
Merge branch 'max_dayl_varorb'
b42fe14 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jul 5, 2024
@ekluzek
Merge tag 'clm5.0.dev012' into release-clm5.0
52c2185 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jul 5, 2024
@ekluzek
Merge tag 'clm5.0.dev012' into fincleanup
faa6cc3 
Fixes for variable_year orbital mode

Fixes for correctness and exact restartability with variable_year
orbital mode:

(1) Update max day length (max_dayl) each time step, rather than just
    updating it once in initialization

(2) Update to a cime version that has a fix for datm, which updates the
    orbital parameters (used for solar zenith angle-based interpolation)
    each time step, rather than just once in initialization

Fixes ESCOMP#379
Fixes ESCOMP#260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billsacks billsacks

Labels
bug something is working incorrectly priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Projects
None yet
Milestone
cesm2
Development

No branches or pull requests
1 participant
@billsacks