Add line about documentation in PR template #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsrabin
added
tag: simple bfb
test: none
ekluzek
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Awesome, thank you.
Should this also be added to the ChangeLog template file (doc/.ChangeLog_template)? Although moving to having more things integrated into github is a better workflow. But, it may also be good to have it in both places...
I'd actually like to move to a workflow that manages the ChangeLog with github actions, based on a talk I saw at SEA ISS. But, that's a longer term thing...
|
Good thinking @ekluzek! Now added; merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As discussed in the CTSM SE meeting today, this PR adds a line about documentation to the PR template.
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #): None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any: None