Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bunch of ignore patterns for vim #567

Merged
merged 1 commit into from
May 1, 2020

Conversation

billsacks
Copy link
Member

From
https://github.com/github/gitignore/blob/master/Global/Vim.gitignore

Motivated by the fact that a .swp file appeared in a PR. We probably
don't need all of these, but it looks like they should be safe to
include (i.e., I can't imagine a real file having a name like one of
these patterns, given that most of them begin with '.' or '_').

Specific notes

Contributors other than yourself, if any: none

CTSM Issues Fixed (include github issue #): none

Are answers expected to change (and if so in what way)? no

Any User Interface Changes (namelist or namelist defaults changes)? no

Testing performed, if any: none

From
https://github.com/github/gitignore/blob/master/Global/Vim.gitignore

Motivated by the fact that a .swp file appeared in a PR. We probably
don't need all of these, but it looks like they should be safe to
include (i.e., I can't imagine a real file having a name like one of
these patterns, given that most of them begin with '.' or '_').
@billsacks billsacks added the documentation additions or edits to user-facing documentation label Nov 9, 2018
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at some opinions on this and some don't give lists as long as this. But, I like just referencing a source where someone has figured this out. I don't think the matches are likely to hit anything that we don't want ignored. So I think this is good.

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 10, 2018

Like other's I might put this on the release branch first.

@ekluzek ekluzek added the PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete label Dec 10, 2018
@billsacks billsacks assigned billsacks and unassigned ekluzek Jan 9, 2019
ekluzek added a commit to ekluzek/CTSM that referenced this pull request Jan 15, 2019
@ekluzek
Copy link
Collaborator

ekluzek commented Jan 15, 2019

I've put this on the release branch.

@billsacks billsacks assigned ekluzek and unassigned billsacks Jan 28, 2019
@ekluzek ekluzek merged commit d500a01 into ESCOMP:master May 1, 2020
@billsacks billsacks deleted the more_ignores branch May 1, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation additions or edits to user-facing documentation PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants