dz --> dz_lake bug-fix in LakeTemperatureMod.F90 line 960 #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran Hobart's test suite. Then... @billsacks I generated the baselines for dev050 on cheyenne and hobart while running the above mentioned tests. I will update the /doc directory next. |
|
@slevisconsulting thanks a lot for this. It looks to me like this is ready to go. Is tat right? If so, I'll merge it. |
|
Yes, that's right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As described in the title plus a comment correction.
Specific notes
Contributors other than yourself, if any:
@billsacks @dlawrenncar
CTSM Issues Fixed (include github issue #):
fixes #760
Are answers expected to change (and if so in what way)?
Only in diagnostic variable WTGQ
Testing performed, if any:
Cheyenne test suite FAILs with DIFFs from dev049 baseline.
The following commands...
./summarize_cprnc_diffs -basedir /glade/scratch/slevis/tests_0712-173856ch -testid '*'
vi cprnc.summary.*.by_varname
...confirm that only WTGQ is different from dev049.
I will repeat on Hobart.