Update standard and function names plus major code clean-up #67
Conversation
…composition dependent (Github issue ESCOMP#22).
…me missed kessler variables.
… to improve scheme name accuracy.
… of dry air gas constant
…condensed_water'.
…or Kessler, and fix stdname bug.
nusbaume
added
documentation
|
@PeterHjortLauritzen I mostly just requested your review here to see if the updated standard names and physics routine names sound reasonable to you. However if you end up not having the time to review then just let me know and I'll take you off the review list. Thanks! |
| @@ -187,20 +124,20 @@ subroutine wet_to_dry_water_vapor_run(ncol, nz, pdel, pdeldry, qv, qv_dry, & | |||
|
|
|||
| integer, intent(in) :: ncol | |||
There was a problem hiding this comment.
The conversion from wet to dry and dry to wet mixing ratios is general. I am curious why there are separate calls for water vapor, rain, etc. to convert from wet to dry. Could we use a generic subroutine instead?
There was a problem hiding this comment.
We currently have these separate calls for legacy reasons, i.e. we had converted Kessler before we had any general way to deal with constituents in the framework.
However, I agree that we should have generic wet <-> dry conversion routines, and now that we have a constituents object that should be doable. I can make an issue about it so that we remember to tackle it at some point in the future.
There was a problem hiding this comment.
I just created the issue, which can be found here: #68
Merge pull request ESCOMP#67 from nusbaume/updated_standard_names
The main purpose of this PR is to update the CCPP standard names to match the internal AMP agreed-upon names, as well as rename some of the physics routines to make them less ambigious and more accurate. Along with these changes, significant code cleanup was performed along with some minor bug fixes, with the goal being to produce bit-for-bit results using the same repo version in both CAM and CAM-SIMA.
Fixes #60
Fixes #61
Fixes #62
Fixes #64