Diffusive wave routing implementation #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Generalize numerical discretization with weights between previous and current time step so can use fully explicit, implicit, or Crank-Nicolson 2. Added downstream boundary condtion schemes - absorbing, or Neumann 3. Added brief descriptions in the method
|
Comparison of the routed flow with different methods.
DWR basin in Idaho. Daily routed flows at the outlet of the basin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added per-reach diffusive wave routine routine (dfw_route.f90)
restart I/O
activated df routing option
routOpt=5 to activate diffusive wave method (this deactivates the other routing methods).
Checked the followings:
[x ] Compilation with gnu
[x ] Compilation with intel
[x ] Tested functionality with MERIT-Hydro global network with CLM5.0 runoff for year 1980 at daily step
[x ] restart test with above setup.
[x ] Tested with HDMA global network with CLM5.0 runoff for year 1980 at daily step.
[x ] restart test with above setup.
Restart test:
run one year with monthly outputs for both history and restart files (restart is dropped 1st day of the month) for 12 months.
run again, starting at August 1st with August 1st restart file.
compare history files from 1 and 2 for history files (August through December)
Detailed science evaluation (inc. numerical stability) is still needed