Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a custom grid option for cesm-coupling #345

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Add a custom grid option for cesm-coupling #345

merged 2 commits into from
Apr 5, 2023

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Feb 16, 2023

Add ability to add a custom grid option (with ROF_GRID=MIZU_USRDAT) so that you can do a custom grid setup.

Fixes #343

@ekluzek ekluzek added the enhancement Improving usability, performance or other types of enhancements label Feb 16, 2023
@nmizukami
Copy link
Collaborator

Hi @ekluzek, thanks! but... could you pull-request to cesm-coupling branch instead of main??

@ekluzek ekluzek changed the base branch from main to cesm-coupling February 17, 2023 21:41
nmizukami
nmizukami reviewed Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@nmizukami nmizukami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed one thing - ancil_dir. I think user needs to set this in user_ctl_mizuroute

Also, when you create the case, is a user notified that ancil_dir and fname_ntopOld need to be set?

cime_config/buildnml Show resolved Hide resolved
@nmizukami nmizukami merged commit c40456f into ESCOMP:cesm-coupling Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmizukami nmizukami nmizukami left review comments

Assignees

@nmizukami nmizukami

Labels
enhancement Improving usability, performance or other types of enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a custom grid option to ctsm-coupling buildnml
2 participants
@ekluzek @nmizukami