Fixed upstream reach detection for cesm-coupling branch #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontributory areas so there is flow coming from the upstreams
nmizukami
added
cesm-coupling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use goodBas parameter to detect upstream reaches that has flows.
goodBas is a logical parameter and True means contributory area is greater than and False means that this reach does not have any associated areas in upstream (so 0 contributory areas)
See PR #346 (the same fix done in the serial code)
This fix does not affect the simulation using HDMA and MERIT river network but will fix some error encountered when using NHDPlus river network (for DW, MC and KWE routing method).