Typescript refactor #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saltz
requested review from
Svenmarim,
hugovandevliert,
roelvdboom,
quintaartsen and
TimoF97
Svenmarim
reviewed
Mar 29, 2019
TimoF97
requested changes
Mar 29, 2019
TimoF97
approved these changes
Mar 29, 2019
Svenmarim
approved these changes
Mar 29, 2019
saltz
added a commit
that referenced
this pull request
Apr 2, 2019
* restructure and rename * add repository pattern and dependency injection * rename dependancy * implement repository * add configuration encryption and injection * fix typos found by @Svenmarim in #1 * fix type found by @TimoF97 in #1 * implement switch for future compatibility @TimoF97 * add appsettings to build, fix targeted dependencies, fix logger save location * fix npm lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored (rewrote) the project to typescript.
What is done
What needs to be done