Remove redundant check of mpi-tag values #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2018 10:01
The `mpi_attr_get` function, which is used to determine the value of MPI_TAG_UB, is not available in the mpi-serial implementation. This function was being used to throw an exception when the max MPI tag was exceeded and report what the max tag is, however, MPI itself will throw this exception (but not report what the max tag is), so it is not necesary. Removing it fixes mpi-serial builds. Fixes #2890
jedwards4b
requested changes
Oct 30, 2018
jedwards4b
approved these changes
Oct 30, 2018
jhkennedy
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Apr 9, 2019
In ESMCI/cime#2804 and ESMCI/cime#2892, the MPI tag generation for MCT was adjusted to allow more than ~30 multi-instance runs fixing #2487. This patch is required in order to run Salil's climate reproduceability tests on maint-1.0, to determine the reporoduceablility of simulations on Cori which were originally run on Edision.
singhbalwinder
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Apr 23, 2019
#2877) Multiple mods for maint-1.0 to run compset F1850C5-CMIP6 and nbfb tests This PR adds following 4 fixes: 1. Fixes the land initial conditions for CMIP6 compset: Adds the land/ocean mask for the existing land initial conditions to only define a land initial condition file for appropriate resolutions. 2. Apply maximum MPI tag value patch: Context: @rljacob requested the CMDV-SM team apply their climate reproducibility tests to maint-1.0 to determine if the simulations run on Edison are reproducible on Cori. This patch is required in order to run Salil's multivariate climate reproducible tests. Changes: In ESMCI/cime#2804 and ESMCI/cime#2892, the MPI tag generation for MCT was adjusted to allow more than ~30 multi-instance runs fixing #2487 and ESMCI/cime#2890. This PR applies these changes to Maint-1.0. 3. Adds TSC and NPG tests nbfb tests: This fix adds python scripts for nbfb tests which were missing in maint-1.0. Adding these tests will allow us to run these tests using maint1.0 4. Fixes a bug in PIO1 which was fixed in master via CIME update: This bug was fixed in master branch via a CIME update (see 8352dd4). [BFB] * singhbalwinder/atm/mods-for-nbfb-test: Fixes a bug in pio1 Adds tsc and npg tests MPI tag fix Land init fix for missing mask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because MPI-serial doesn't have the
MPI_attr_getfunction, PR #2804 broke MP-serial builds as discussed in #2890 . This removes a redundant exception that usesMPI_attr_getto determine the max MPI tag value, and report it and when it is exceed. MPI will still throw an exception when it is exceeded, but doesn't report the maximum value. I also added an MPI-serial test to cime_developer test suite.Test suite: ./scripts_regression_tests on titan, ./create_test cime_developer (with new SMS_D_Ln9_Mmpi-serial.f19_g16_rx1.A test) on anvil
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #2890
User interface changes?: N
Update gh-pages html (Y/N)?: N/A
Code review: