Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cpl7 unit tests #4536

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

billsacks
Copy link
Member

In trying to get the unit tests running on derecho, I ran into problems with the cpl7 unit tests. It seems like these aren't useful anymore: they at least aren't useful to CESM; @rljacob are they useful to E3SM?

Test suite: Just ran ./scripts_regression_tests.py test_sys_unittest.py - on derecho, cheyenne and my mac. I ran in the context of CTSM master. This needed changes in the share code and ccs_config (in separate PRs that I am opening) - but it won't do any harm to bring in this cime change separately from those (the others are just needed for unit tests to pass on derecho).
Test baseline: N/A
Test namelist changes: none
Test status: bit for bit

Fixes none

User interface changes?: N

Update gh-pages html (Y/N)?: N

This was only needed by the cpl7 unit tests; since we are no longer
building / running the cpl7 unit tests, we can stop building mct, too.
@billsacks
Copy link
Member Author

A bit more details: the issue I ran into on derecho was in the build of mpi-serial for the unit tests; we needed to build mpi-serial in order to build mct, and needed to build mct in order to build the cpl7 unit tests. On derecho, I got this and many similar errors:

/glade/work/sacks/ctsm_code/ctsm/libraries/mct/mpi-serial/send.c:218:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]

I haven't spent any time trying to resolve that issue, but figured that the cpl7 unit tests may not be worth maintaining at this point. But @rljacob if you feel differently, I can try to dig into this a bit.

@jedwards4b
Copy link
Contributor

You need to set the flags:
-Wno-error=implicit-int
-Wno-error=implicit-function-declaration

For the intel c compiler (and I think any other llvm based compiler).

@rljacob
Copy link
Member

rljacob commented Dec 7, 2023

No we don't run those cpl7 unit tests. I'm fine with removing them from this file.

@billsacks
Copy link
Member Author

Thanks @jedwards4b and @rljacob . @jedwards4b thanks for the tip on how to get around this issue, but since these unit tests are no longer important to either CESM or E3SM, it seems like the best approach is just to stop running them so we don't need to try to maintain them moving forward. Do you agree?

@jedwards4b
Copy link
Contributor

I do, thank you.

@billsacks billsacks merged commit f7d44bb into ESMCI:master Dec 7, 2023
@billsacks billsacks deleted the remove_cpl7_unit_tests branch December 7, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants