Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thetao CESM2 z-level ("olevel") needs fix to convert units from cm to m #859

Open
valeriupredoi opened this issue Nov 9, 2020 · 6 comments
Assignees
Labels
bug Something isn't working fix for dataset Related to dataset-specific fix files

Comments

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Nov 9, 2020

CESM2 (eg /badc/cmip6/data/CMIP6/CMIP/NCAR/CESM2/historical/r1i1p1f1/Omon/thetao/gn/latest/thetao_Omon_CESM2_historical_r1i1p1f1_gn_185001-201412.nc on Jasmin) has depth (generic vertical level, olevel) units in centimeters (and its bounds in meters!) but the cmor checks in the preprocessor are not picking this up). Run test:

---
documentation:
  description: |
    Test

  authors:
    - righi_mattia

diagnostics:
  BerkeleyEarth:
    description: BerkeleyEarth check
    variables:
      thetao:
    additional_datasets:
#/badc/cmip6/data/CMIP6/CMIP/NCAR/CESM2/historical/r1i1p1f1/Omon/thetao/gn/latest/thetao_Omon_CESM2_historical_r1i1p1f1_gn_185001-201412.nc
      - {dataset: CESM2, project: CMIP6, exp: historical, mip: Omon, ensemble: r1i1p1f1, grid: gn, start_year: 1990, end_year: 1995}
    scripts: null

I have forgotten - are we expecting checks on olevel or this is something we should fix via a fix file? seems a bit odd since it's a valid dimensional coordinate and not even --check_level strict picks up the weird units and wonky bounds 🍺

@valeriupredoi valeriupredoi added bug Something isn't working fix for dataset Related to dataset-specific fix files labels Nov 9, 2020
@valeriupredoi
Copy link
Contributor Author

amigos ping @jvegasbsc

@jvegreg
Copy link
Contributor

jvegreg commented Nov 16, 2020

I have forgotten - are we expecting checks on olevel or this is something we should fix via a fix file? seems a bit odd since it's a valid dimensional coordinate and not even --check_level strict picks up the weird units and wonky bounds 🍺

@sloosvel has an open PR for generic levels: #598

Let's get it merged before this

@valeriupredoi
Copy link
Contributor Author

sweet - can I reviews it?

@valeriupredoi
Copy link
Contributor Author

arite, #598 is now in da master and we can go ahead and write a fix for that CESM2 broken data, I'll do it today hopefully

@zklaus
Copy link

zklaus commented Nov 24, 2020

@valeriupredoi are you still up for this? In that case I'll change the assignment.

@valeriupredoi
Copy link
Contributor Author

yeah, this totally fell off my radar scope - yes, I'll assign meself

@valeriupredoi valeriupredoi assigned valeriupredoi and unassigned zklaus and ledm Nov 24, 2020
@valeriupredoi valeriupredoi changed the title CESM2 z-level ("olevel") in cm and not fixed on the fly nor reported by cmor checks CESM2 z-level ("olevel") needs fix to convert units from cm to m Nov 24, 2020
@valeriupredoi valeriupredoi changed the title CESM2 z-level ("olevel") needs fix to convert units from cm to m thetao CESM2 z-level ("olevel") needs fix to convert units from cm to m Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

No branches or pull requests

4 participants