-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thetao CESM2 z-level ("olevel") needs fix to convert units from cm to m #859
Comments
amigos ping @jvegasbsc |
@sloosvel has an open PR for generic levels: #598 Let's get it merged before this |
sweet - can I reviews it? |
arite, #598 is now in da |
@valeriupredoi are you still up for this? In that case I'll change the assignment. |
yeah, this totally fell off my radar scope - yes, I'll assign meself |
CESM2 (eg
/badc/cmip6/data/CMIP6/CMIP/NCAR/CESM2/historical/r1i1p1f1/Omon/thetao/gn/latest/thetao_Omon_CESM2_historical_r1i1p1f1_gn_185001-201412.nc
on Jasmin) has depth (generic vertical level,olevel
) units incentimeters
(and its bounds in meters!) but the cmor checks in the preprocessor are not picking this up). Run test:I have forgotten - are we expecting checks on
olevel
or this is something we should fix via a fix file? seems a bit odd since it's a valid dimensional coordinate and not even--check_level strict
picks up the weird units and wonky bounds 🍺The text was updated successfully, but these errors were encountered: