Skip to content

Commit

Permalink
Pin matplotlib to <3.3 and add compilers (#1898)
Browse files Browse the repository at this point in the history
  • Loading branch information
bouweandela authored Nov 4, 2020
1 parent 6fa4b19 commit 9c79cbb
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ channels:

dependencies:
# Python packages that cannot be installed from PyPI:
- compilers
- gdal
- esmpy
- esmvalcore>=2.1.0,<2.2
- iris>=2.2.1,<3
- matplotlib>=3,<3.3

This comment has been minimized.

Copy link
@valeriupredoi

valeriupredoi Nov 4, 2020

Contributor

too late to the show but we should have done matplotlib>3.1,<3.3 because we know from @koldunovn that 3.1 contains a bug that affects at least one diagnostic

# Non-Python dependencies
- cdo>=1.9.7
- eccodes!=2.19.0 # cdo dependency; something messed up with libeccodes.so
Expand All @@ -21,5 +23,3 @@ dependencies:
# Multi language support:
- ncl>=6.5.0 # this should always install 6.6.0 though
- r-base>=3.5
- r-curl # Dependency of lintr, but fails to compile because it cannot find libcurl installed from conda.
- r-udunits2 # Fails to compile because it cannot find udunits2 installed from conda.
5 changes: 2 additions & 3 deletions package/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ outputs:
- jinja2
- joblib
- lime
- matplotlib>=3
- matplotlib>=3,<3.3

This comment has been minimized.

Copy link
@valeriupredoi

valeriupredoi Nov 4, 2020

Contributor

same here and below 👍

- natsort
- nc-time-axis
- netCDF4
Expand Down Expand Up @@ -131,11 +131,10 @@ outputs:
requirements:
run:
- cdo>=1.9.7
- compilers
- esmvaltool-python
- nco
- r-base>=3.5
- r-curl # Dependency of lintr, but fails to compile because it cannot find libcurl installed from conda.
- r-udunits2 # Fails to compile because it cannot find udunits2 installed from conda.

about:
home: https://www.esmvaltool.org
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
'jinja2',
'joblib',
'lime',
'matplotlib',
'matplotlib>=3,<3.3',
'natsort',
'nc-time-axis', # needed by iris.plot
'netCDF4',
Expand Down

0 comments on commit 9c79cbb

Please sign in to comment.