Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization of "development" branches between ESMValTool and ESMValTool-private #71

Closed
koldunovn opened this issue Jun 26, 2017 · 8 comments

Comments

@koldunovn
Copy link
Contributor

Are there plans to sync the branches?

My problem is - I would like to start developing diagnostic in the private repository (ESMValTool-private), but I need features already added to "development" branch of the public one (ESMValTool). I can re-implement the features in the private branch, but it's kind of ugly.

Ping @mattiarighi

@nielsdrost
Copy link
Member

Yes, I think it makes sense to keep the "master" and "development" branches of ESMValTool synchronized at all times.

This would mean every pull request to either branches in either repo's would need to be followed up with a git pull-push synchronize step. Perhaps we should make a script.

@bulli92
Copy link
Contributor

bulli92 commented Jun 26, 2017

Agree, only point is that we need to ensure that also the devbranch is a running version.
But that's what is envisaged anyway.

@koldunovn
Copy link
Contributor Author

The possible problem is that private and public repositories are not linked in github, at least I can not make PR to one from another. Maybe I don't have enough rights.

@bulli92
Copy link
Contributor

bulli92 commented Jun 26, 2017 via email

@nielsdrost
Copy link
Member

nielsdrost commented Jun 26, 2017

Yes, this is an unfortunate side effect of the workaround we used to get two copies of the same repo into one GitHub organization with different public/private settings: as far as GitHub is concerned, these two repo's are not related in any way.

@bulli92 is right in that on the command line it is only a few lines (though you have to be careful to get it right not to mess up some branch)

I discussed this with @bjoernbroetz before (actually before the github was setup). I guess we should write that down somewhere :-)

@koldunovn
Copy link
Contributor Author

Can someone then, please, take an action on this?

@bulli92
Copy link
Contributor

bulli92 commented Jun 26, 2017

@mattiarighi @axel-lauer @bjoernbroetz @veyring

can you please comment on this. I think we need some general agreement and responsibility assignment.

But first we would need to agree on the overall procedure to always keep the masters and dev's in sync. Do you agree with such an approach?

@axel-lauer
Copy link
Contributor

The master / development branches have been synchronized (September 1, 2017).

For the future, we developed and tested a set of instructions for the core development team how to synchronize the master and development branches in the different repositories. Currently, the synchronization has to be done by hand. The current strategy is that synchronization is done as soon as one of the master or development branches is modified (in any of the repositories). The core team member performing the updates of the master / development branch would be the primary person responsible for synchronizing the branches / repositories. The instructions are available for discussion and further refinement here on the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants