Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for recipe_seaice_drift.yml: fix CRS transformer for "North Pole Stereographic" #3531

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

flicj191
Copy link
Contributor

@flicj191 flicj191 commented Feb 13, 2024

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@flicj191 flicj191 marked this pull request as ready for review February 13, 2024 04:44
@flicj191 flicj191 requested a review from a team February 13, 2024 05:13
@valeriupredoi valeriupredoi changed the title add always xy to transformer Fix for recipe_seaice_drift.yml: add always xy to transformer Feb 14, 2024
@valeriupredoi
Copy link
Contributor

@esmvalbot please run recipe_seaice_drift.yml

@esmvalbot
Copy link

esmvalbot bot commented Feb 14, 2024

Since @valeriupredoi asked, ESMValBot will run recipe recipe_seaice_drift.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Feb 14, 2024

ESMValBot is sorry to report it failed to run recipe recipe_seaice_drift.yml: exit is 1, output has been generated here

@valeriupredoi
Copy link
Contributor

bot's failing since it's missing daily NSIDC-0116-nh data - @flicj191 could you pls confirm the recipe is running for you? If so, I'll approve, and we good to go - please remember to fix the PR description and checked/unchecked boxes 🍺

@bouweandela
Copy link
Member

In order to avoid creating extra work for the future release manager (who will need to investigate and report issues), I would recommend that someone else than the author of a pull request runs the recipe. Could you have a go yourself @valeriupredoi? Or would you like me to do it?

@rbeucher
Copy link
Contributor

Works for me!

@rbeucher rbeucher changed the title Fix for recipe_seaice_drift.yml: add always xy to transformer Fix for recipe_seaice_drift.yml: fix CRS transformer for "North Pole Stereographic" Feb 20, 2024
@bouweandela bouweandela merged commit 0c933ad into main Feb 20, 2024
6 checks passed
@bouweandela bouweandela deleted the recipe_seaice_drift branch February 20, 2024 06:56
@valeriupredoi
Copy link
Contributor

cheers @rbeucher and @bouweandela 🍻

@ehogan ehogan added the bug label Jun 27, 2024
@ehogan ehogan added this to the v2.11.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recipe_seaice_drift.yml no longer runs
5 participants