Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nano everywhere #96

Merged
merged 4 commits into from
Jul 31, 2020
Merged

Use nano everywhere #96

merged 4 commits into from
Jul 31, 2020

Conversation

sverhoeven
Copy link
Contributor

@sverhoeven sverhoeven commented Jul 31, 2020

Also added shortcut for line numbers to help section description

Pull Request checklist

We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.


Before you start

  • Read CONTRIBUTING.md.
  • Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
  • All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #77

Also added shortcut for line numbers to help section description
@sverhoeven sverhoeven marked this pull request as ready for review July 31, 2020 09:58
@SarahAlidoost SarahAlidoost self-requested a review July 31, 2020 11:52
SarahAlidoost
SarahAlidoost previously approved these changes Jul 31, 2020
Copy link
Contributor

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sverhoeven thank you. just a minor suggestion.

Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@SarahAlidoost SarahAlidoost merged commit 42efc33 into master Jul 31, 2020
@SarahAlidoost SarahAlidoost deleted the nano-everywhere-77 branch July 31, 2020 12:21
@SarahAlidoost SarahAlidoost restored the nano-everywhere-77 branch July 31, 2020 12:21
@Peter9192 Peter9192 deleted the nano-everywhere-77 branch June 22, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the same text editors in episodes
2 participants