-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to use mamba #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
reviewed
Feb 16, 2022
prusse-martin
force-pushed
the
fix-mamba-detection
branch
from
February 23, 2022 21:03
f1fbac7
to
a29e71f
Compare
nicoddemus
reviewed
Feb 24, 2022
nicoddemus
requested changes
Feb 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Besides defaulting to conda
as the env manager, we also need to update the docs.
prusse-martin
force-pushed
the
fix-mamba-detection
branch
from
March 4, 2022 19:05
a29e71f
to
6954c29
Compare
prusse-martin
changed the title
Iterate over parent procs to detect the env manager
Add an option to use mamba
Mar 4, 2022
prusse-martin
force-pushed
the
fix-mamba-detection
branch
2 times, most recently
from
March 4, 2022 19:25
51e374d
to
a985cb3
Compare
prusse-martin
force-pushed
the
fix-mamba-detection
branch
from
March 4, 2022 19:40
a985cb3
to
ca4165d
Compare
(For some reason I was hopping github will add a snippet to that comment) |
nicoddemus
requested changes
Mar 6, 2022
Nice work! |
prusse-martin
force-pushed
the
fix-mamba-detection
branch
from
March 7, 2022 11:24
ef80b6c
to
cbf5a75
Compare
(Note this is still marked as draft) |
nicoddemus
approved these changes
Mar 7, 2022
nicoddemus
reviewed
Mar 7, 2022
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #133
@nicoddemus @marcelotrevisani
Are you guys with this approach?