Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to use mamba #134

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

prusse-martin
Copy link
Member

@prusse-martin prusse-martin commented Feb 16, 2022

Related issue: #133

@nicoddemus @marcelotrevisani
Are you guys with this approach?

W:\my\Projects\mamba-test (master -> origin)
λ mamba devenv
!!! __call_conda_env_update proc_exe: conda-devenv
!!! __call_conda_env_update proc_exe: python
!!! __call_conda_env_update proc_exe: mamba
> Executing: mamba env update --file W:\my\Projects\mamba-test\environment.yml --prune
!!! __call_conda_env_update command: ['mamba', 'env', 'update', '--file', 'W:\\my\\Projects\\mamba-test\\environment.yml', '--prune']
!!! _call_conda env_manager: mamba
...
Transaction

  Prefix: W:\my\envs\mamba-devenv

  All requested packages already installed



Looking for: ["python[version='>=3.6']"]


Preparing transaction: done
Verifying transaction: done
Executing transaction: done
#
# To activate this environment, use
#
#     $ conda activate mamba-devenv
#
# To deactivate an active environment, use
#
#     $ conda deactivate
...

conda_devenv/devenv.py Outdated Show resolved Hide resolved
conda_devenv/devenv.py Outdated Show resolved Hide resolved
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Besides defaulting to conda as the env manager, we also need to update the docs.

@prusse-martin prusse-martin changed the title Iterate over parent procs to detect the env manager Add an option to use mamba Mar 4, 2022
@prusse-martin prusse-martin force-pushed the fix-mamba-detection branch 2 times, most recently from 51e374d to a985cb3 Compare March 4, 2022 19:25
@prusse-martin
Copy link
Member Author

prusse-martin commented Mar 4, 2022

#136 (comment)

After merging this I pretend to rebase #134 to drop python 3.6 there.

(For some reason I was hopping github will add a snippet to that comment)

CHANGELOG.rst Outdated Show resolved Hide resolved
docs/usage.rst Outdated Show resolved Hide resolved
@nicoddemus
Copy link
Member

Nice work!

@nicoddemus
Copy link
Member

(Note this is still marked as draft)

@prusse-martin prusse-martin marked this pull request as ready for review March 7, 2022 13:44
CHANGELOG.rst Outdated Show resolved Hide resolved
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
@prusse-martin prusse-martin merged commit 7970bc5 into ESSS:master Mar 7, 2022
@prusse-martin prusse-martin deleted the fix-mamba-detection branch March 7, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants