Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pybind11 inclusion in generated CMakeLists.txt #59

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Improve pybind11 inclusion in generated CMakeLists.txt #59

merged 1 commit into from
Jul 4, 2019

Conversation

tadeu
Copy link
Member

@tadeu tadeu commented Jul 3, 2019

No description provided.

@tadeu tadeu requested a review from nicoddemus July 3, 2019 22:21
nicoddemus
nicoddemus approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just take a look at the tests please 👍

@tadeu
Copy link
Member Author

tadeu commented Jul 4, 2019

I've tested it locally in both Windows and Linux and it's working. AppVeyor here seems to have unrelated problems (can't find Python). The problem in TravisCI seem related to the mix of conda + pip, something that we don't need downstream, as we use only conda devenv. I'm merging this now, as this is needed to fix things downstream, but I'll take a look at the CI issues ASAP.

@tadeu tadeu merged commit d5bcab9 into master Jul 4, 2019
@tadeu tadeu deleted the fb-RES-123-remove-workaround branch July 4, 2019 12:42
@tadeu tadeu mentioned this pull request Jul 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tadeu @nicoddemus