Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot insert existing value to full set #783

Closed
ismailtzn opened this issue Nov 2, 2023 · 4 comments · Fixed by #782
Closed

Cannot insert existing value to full set #783

ismailtzn opened this issue Nov 2, 2023 · 4 comments · Fixed by #782
Assignees
@ismailtzn
Labels
bug

Comments

@ismailtzn
Copy link
Contributor

When I try to insert a value to full set, it always throws set_full error, even if the value was already in the set.
@ismailtzn ismailtzn mentioned this issue Nov 2, 2023
Merged
@jwellbelove
Copy link
Contributor

This may also be an issue for etl::flat_set and etl::unordered_set.

@ismailtzn
Copy link
Contributor Author

You are right, I will look them too 😄

@ismailtzn
Copy link
Contributor Author

I checked etl::reference_flat_set, etl::flat_set and etl::unordered_set, this issue does not occur for etl::reference_flat_set and etl::flat_set. For those two I added tests. I tried to fix etl::unordered_set also.

By the way, I couldn't see any contribution instructions, so I created a pull request directly. If you follow a particular way of accepting contributions, I'd love to do it your way.

jwellbelove pushed a commit that referenced this issue Nov 24, 2023
#787 etl::expected doesn't compile with ETL_LOG_ERRORS
63d1a64 
Updated CI scripts
#786 u8string
#783 Cannot insert existing value to full set
#781 etl::multi_span::iterator::operator *() fails if first span is empty
#780 endian enum_type produces useless-cast warnings
#779 hash.h: warnings produced with -Wfloat-equal
@jwellbelove
Copy link
Contributor

Fixed 20.38.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailtzn ismailtzn

Labels
bug
Projects
Embedded Template Library
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set is full error when adding existing item ismailtzn/etl
2 participants
@jwellbelove @ismailtzn