fixed some compiler warnings #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adow - Wnon-virtual-dtor
|
Your changes have broken the build. |
|
Yeah, seen that :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am starting to use the etl library on an cortex-m4 target with gcc.
There are some compiler warnings that I fixed. There are probably more of them in the whole code but I just fixed what I came across so far. With this pull request I want to find out if you are interested in having those warnings fixed and if you like this style.
Those are the relevant warnings.
I know that those warnings could be safely ignored for these specific cases but as this is a template library it should build cleanly no matter what warnings are enabled in the application code using it.