Feature/add back insert iterator #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mainly a copy of the STL implementation found in LLVM. - Add test_back_insert_iterator unit test.
jesseli2002
reviewed
Sep 15, 2022
jesseli2002
suggested changes
Sep 15, 2022
https://en.cppreference.com/w/cpp/iterator/back_insert_iterator Strictly following the C++ STL would have container_ be container.
|
The all iterator tags should use the There is also the complementary |
- Make back_insert_iterator available to C++03 - Add ETL_CONSTEXPR17,ETL_NODISCARD and ETL_USING_CPP11 - Replace std:move usage by etl::move - Update doc
evantill
force-pushed
the
feature/add-back_insert_iterator
branch
from
4dd67f9
to
5eb8e4f
Compare
jwellbelove
changed the base branch from
development
to
feature/#603-add-back-insert-iterator
|
Was there a particular reason that you used |
I can not remember the link but I have adapted the source from the std implementation and the |
jwellbelove
pushed a commit
that referenced
this pull request
Oct 20, 2022
* Add back_inserter implementation - Mainly a copy of the STL implementation found in LLVM. - Add test_back_insert_iterator unit test. * Add documentation and use ETL_OR_STD macro * Add MIT License in header * Move back_insert_iterator into iterator.h * Remove unused code * Strictly follow the C++ STL naming https://en.cppreference.com/w/cpp/iterator/back_insert_iterator Strictly following the C++ STL would have container_ be container. * Make the check for C++11 clearer * Run the unit test only for C++11 * Add front_insert_iterator - Make back_insert_iterator available to C++03 - Add ETL_CONSTEXPR17,ETL_NODISCARD and ETL_USING_CPP11 - Replace std:move usage by etl::move - Update doc * Use explicit namespace for adressof() and move().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
back_insert_iteratorandback_inserter()