[bug] Fix non-usages of key equal function #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwellbelove
changed the base branch from
master
to
hotfix/#606-fix-non-usages-of-key-equal-function
jwellbelove
merged commit 5dee901
into
ETLCPP:hotfix/#606-fix-non-usages-of-key-equal-function
jwellbelove
added a commit
that referenced
this pull request
Oct 4, 2022
jwellbelove
pushed a commit
that referenced
this pull request
Oct 20, 2022
Co-authored-by: Jesse <jli@planarmotor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some more places where
Key::operator==orKey::operator!=were being used instead ofkey_equal_function; replaced them and added tests to demonstrate the previously bad behaviour.